fix: include root package in pnpm workspace (repairs release workflow) - #403
Merged
Conversation
Adding the docs package as 'packages: [docs]' made changesets treat the root
library as the excluded root package, breaking the release workflow
('changeset ... which is not in the workspace'). List the root explicitly so
both the library and docs are workspace members.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The docs PR (#402) added
packages: [docs]topnpm-workspace.yaml. That madechangesets/manypkg treat the root library as the excluded root package, so the
releasejob now fails:(pnpm itself still shows the root project, but manypkg — which changesets uses — does not.)
Fix
List the root explicitly alongside docs:
Verified locally
pnpm changeset status→@labdigital/commercetools-mockbumped at minor ✅pnpm --filter @labdigital/commercetools-mock-docs build→ 26 pages ✅pnpm check(biome + tsc) → 322 files, no errors ✅