fix: remove stray debug log statement from SetWorker function - #116
Open
saiashok0981 wants to merge 1 commit into
Open
fix: remove stray debug log statement from SetWorker function#116saiashok0981 wants to merge 1 commit into
saiashok0981 wants to merge 1 commit into
Conversation
A stray debug log.Println call with the literal string 'roshani' was left in the SetWorker function in pkg/internal/kubernetes-operation.go. This is clearly a leftover from development and causes unintended output on every invocation of kubeslice-cli commands that modify worker slice configuration (e.g. kubeslice-cli edit sliceConfig). The debug statement also required an import of the 'log' package solely for this single call. Removing the statement allows the 'log' import to be dropped as well, reducing unnecessary dependencies within the file. Signed-off-by: saiashok103@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes an accidental debug log.Println call that was left behind in the SetWorker function inside pkg/internal/kubernetes-operation.go.
Motivation
The line log.Println("roshani", len(worker)) was clearly a developer debug statement that was never meant to reach production. It gets printed to stderr every time a user runs kubeslice-cli edit sliceConfig. This is confusing for users and pollutes the output of any script that relies on the CLI. The string "roshani" has no meaning to end users. Removing it also allows the log import to be dropped since it was only used for this one line.
Changes
In pkg/internal/kubernetes-operation.go, the debug log.Println("roshani", len(worker)) line was removed from the SetWorker function. The now-unused "log" import was also removed.
Testing
Verified the rest of the SetWorker logic is completely unchanged.
The build compiles cleanly after the import is removed.
No other code in the file used the log package.
Checklist
Minimal and focused change — only the debug artifact removed
No functional behaviour changed
Commit message uses Conventional Commits format
DCO Signed-off-by included
Signed-off-by:
saiashok103@gmail.com