Skip to content

fix: validate taint effects#18385

Open
immanuwell wants to merge 1 commit into
kubernetes:masterfrom
immanuwell:fix-validate-taint-effects
Open

fix: validate taint effects#18385
immanuwell wants to merge 1 commit into
kubernetes:masterfrom
immanuwell:fix-validate-taint-effects

Conversation

@immanuwell
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Reject invalid node taint effects in kOps validation.

Repro before this: put nvidia.com/gpu:ScheduleSometimes in spec.taints or spec.kubelet.taints. kOps accepted it, then the value could flow into kubelet taints / autoscaler tags. That effect is not a real Kubernetes node taint effect, so this is a tiny config footgun.

Now kOps accepts only NoSchedule, PreferNoSchedule, and NoExecute when an effect is set. Bad values get bounced early, nice.

Which issue(s) this PR fixes:

None found, searched issues/PRs for taint validation bits.

Special notes for your reviewer:

Tested with:

go test ./pkg/apis/kops/util ./pkg/apis/kops/validation ./pkg/model ./nodeup/pkg/model ./pkg/model/awsmodel ./pkg/model/azuremodel

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from hakman May 21, 2026 09:22
@k8s-ci-robot k8s-ci-robot requested a review from zetaab May 21, 2026 09:22
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @immanuwell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants