fix: validate taint effects#18385
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @immanuwell. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Reject invalid node taint effects in kOps validation.
Repro before this: put
nvidia.com/gpu:ScheduleSometimesinspec.taintsorspec.kubelet.taints. kOps accepted it, then the value could flow into kubelet taints / autoscaler tags. That effect is not a real Kubernetes node taint effect, so this is a tiny config footgun.Now kOps accepts only
NoSchedule,PreferNoSchedule, andNoExecutewhen an effect is set. Bad values get bounced early, nice.Which issue(s) this PR fixes:
None found, searched issues/PRs for taint validation bits.
Special notes for your reviewer:
Tested with: