WIP build: disable inlining for nodeup builds#18265
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Apply -gcflags=all=-l only to nodeup release builds to reduce the nodeup binary size without changing compiler flags for kops, protokube, or channels. Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
cc3a500 to
e9acd03
Compare
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Interesting! Does it make a big difference to binary size? Also, I assume you're trying to limit nodeup memory usage? Is it causing problems? We aren't seeing GOMEMLIMIT so that might be an easy win, but we could also start calling GC explicitly after each task has completed, or we could get more "heavyweight" and start capturing pprof heap profiles. But I would like to better understand the problem first (e.g. is it because I suggested running nodeup persistently?) |
Apply
-gcflags=all=-lonly to nodeup release builds to reduce the nodeup binary size without changing compiler flags for kops, protokube, or channels.