distinguish CRD vs built-in pointer guidance in api-conventions#8990
distinguish CRD vs built-in pointer guidance in api-conventions#8990omerap12 wants to merge 3 commits into
Conversation
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
k8s-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/developer-guide
| K -- Yes --> O[Need to distinguish <br/> Unset from Empty?]; | ||
|
|
||
| O -- Yes --> P["USE: Pointer to slice/map <br/> (*[]T or *map[K]V)"]; | ||
| O -- No --> J; |
There was a problem hiding this comment.
Overall, this looks good, although I wonder if splitting this diagram into separate will make it easier to read. First for the built-ins, then for CRDs. Smaller diagrams are easier to read and comprehend.
There was a problem hiding this comment.
I will make another commit that seperates those two and we can see if it makes it easier to understand.
There was a problem hiding this comment.
Nit: but can we make the built-in first?
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
3 participants
Which issue(s) this PR fixes:
Fixes #
Just finished reading this doc. I found this diagram much more informative than the current one.
/cc @soltysh