Repository navigation
Honor assert_hostname in the asyncio client - #2795
Open
Yohan-Senadheera wants to merge 1 commit into
Open
Yohan-Senadheera wants to merge 1 commit into
Yohan-Senadheera wants to merge 1 commit into
Conversation
assert_hostname=False turned off hostname checks in the sync client but had no effect in the asyncio client. Set check_hostname on the SSL context from it when verify_ssl is on. Signed-off-by: Yohan Senadheera <yohansenadheera@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Yohan-Senadheera The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
assert_hostname=Falseturns off hostname checks in the sync client, but has no effect in the asyncio client:rest.pynever reads it. This setsssl_context.check_hostnamefrom it whenverify_sslis on. Withverify_ssloff it is left alone, so certificate verification is not switched back on.rest.pyis generated, so the same change is made in the generator post-processing: kubernetes-client/gen#314Tested with an HTTPS server whose certificate is issued for another hostname, trusted through
ssl_ca_cert:assert_hostname=Falsestill fails withCERTIFICATE_VERIFY_FAILED(hostname mismatch)assert_hostname=Falsereturns 200, and the default still rejects the mismatchThe new unit test fails on master and passes here. All
kubernetes/aio/test/test_generated_api.pytests pass.Which issue(s) this PR fixes:
None filed.
Does this PR introduce a user-facing change?