Repository navigation
Restore the python-dateutil lower bound to 2.8.2 - #2789
Yohan-Senadheera wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Yohan-Senadheera The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @Yohan-Senadheera! |
Dependabot raised the requirement from >=2.8.2 to >=3.0.0, which makes the client impossible to install next to botocore, since botocore pins python-dateutil<3.0.0. The client only uses dateutil.parser.parse, which every 2.x release provides, and the 37.0 changelog documents python-dateutil>=2.8.2. Signed-off-by: Yohan Senadheera <yohansenadheera@gmail.com>
45e64cf to
12d1f4f
Compare
|
thanks for the PR #2790 did the same fix, we can close this PR. |
|
/close |
|
@yliaog: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No problem, glad it's fixed. For reference, this PR had the same change about 45 minutes before #2790. I'd like to keep contributing here, so if there's an issue you'd like help with, I'm happy to take it. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
#2757 raised the python-dateutil requirement to >=3.0.0. botocore needs python-dateutil<3.0.0, so the two can't be installed together anymore. The client only uses
dateutil.parser.parse, which works on 2.x, so this puts the lower bound back to 2.8.2, the value in the 37.0 changelog.Tested with python-dateutil 2.8.2: the client and config tests pass, and it installs next to botocore 1.44.4.
Which issue(s) this PR fixes:
Fixes #2788
Does this PR introduce a user-facing change?