Update dependencies and devcontainer SDKs by brendandburns · Pull Request #1945 · kubernetes-client/csharp

brendandburns · 2026-10-14T04:11:59Z

Summary

combine dependency updates from Bump OpenTelemetry.Instrumentation.Http from 1.15.1 to 1.19.0 #1932, Bump Scriban from 6.2.1 to 7.5.0 #1933, Bump System.IO.Abstractions.TestingHelpers from 22.1.1 to 22.3.0 #1934, and Bump Vecc.YamlDotNet.Analyzers.StaticGenerator from 18.0.0 to 18.1.0 #1937
update the devcontainer from Update devcontainer to support .NET 9 and .NET 10 #1843 to provide .NET 8, 9, and 10 SDKs
preserve Scriban's embedded-source generator setup with PolySharp compatibility attributes
disable Scriban 7.5's new loop and output limits for trusted generator templates

Validation

dotnet build src/KubernetesClient/KubernetesClient.csproj --configuration Release --framework net8.0 --no-restore --target:Rebuild
full traversal build progressed past all Scriban and generated-source failures with no errors before the local execution limit cancelled it

kubernetes-prow · 2026-10-14T04:12:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

🔵 Needs a closer look

Multiple dependency upgrades affect source generation and AOT behavior without a completed full traversal build.

0 open findings

What changed in this PR

Updates dependencies, generator compatibility, and the development container for .NET 8–10.

Changes:

Upgrades four dependencies and adds PolySharp.
Adapts embedded Scriban generation to 7.5 defaults.
Adds a multi-SDK devcontainer.

File	Description
`Directory.Packages.props`	Updates dependency versions and adds PolySharp.
`src/LibKubernetesGenerator/LibKubernetesGenerator.target`	Configures PolySharp for embedded Scriban sources.
`src/LibKubernetesGenerator/GeneratorExecutionContextExt.cs`	Disables limits for trusted generator templates.
`.devcontainer/Dockerfile`	Provides .NET 8, 9, and 10 SDKs.
`.devcontainer/devcontainer.json`	Builds the new Dockerfile-based container.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

🔵 Needs a closer look

The embedded Scriban major-version upgrade needs completed cross-target build validation and human review.

No open issues 🎉

_{Review effort: Balanced}

…1967) * Port devcontainer and Scriban compatibility fixes from #1945 Keep the dependency updates from #1963 while adding PolySharp support and disabling Scriban generation limits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Port xUnit v3 migration from #1797 Match Xunit.StaFact 4 with xunit.v3 4, retain VSTest and serial execution, and update output helpers and OS-specific facts. Remove the unused StaFact reference from the xUnit v2 Kubectl suite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…1967) * Port devcontainer and Scriban compatibility fixes from #1945 Keep the dependency updates from #1963 while adding PolySharp support and disabling Scriban generation limits. * Port xUnit v3 migration from #1797 Match Xunit.StaFact 4 with xunit.v3 4, retain VSTest and serial execution, and update output helpers and OS-specific facts. Remove the unused StaFact reference from the xUnit v2 Kubectl suite. ---------

* Bump the nuget group with 7 updates Bumps Microsoft.Bcl.AsyncInterfaces from 10.0.12 to 10.0.13 Bumps Microsoft.TestPlatform.ObjectModel from 18.10.1 to 18.11.0 Bumps OpenTelemetry.Exporter.Console from 1.19.1 to 1.20.0 Bumps OpenTelemetry.Instrumentation.Http from 1.15.1 to 1.20.0 Bumps Scriban from 6.2.1 to 7.5.1 Bumps System.Text.Json from 10.0.9 to 10.0.13 Bumps Xunit.StaFact from 1.2.69 to 4.0.24 --- updated-dependencies: - dependency-name: Microsoft.Bcl.AsyncInterfaces dependency-version: 10.0.13 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget - dependency-name: Microsoft.TestPlatform.ObjectModel dependency-version: 18.11.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget - dependency-name: OpenTelemetry.Exporter.Console dependency-version: 1.20.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget - dependency-name: OpenTelemetry.Instrumentation.Http dependency-version: 1.20.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: nuget - dependency-name: Scriban dependency-version: 7.5.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget - dependency-name: System.Text.Json dependency-version: 10.0.13 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: nuget - dependency-name: Xunit.StaFact dependency-version: 4.0.24 dependency-type: direct:production update-type: version-update:semver-major dependency-group: nuget ... Signed-off-by: dependabot[bot] <support@github.com> * Fix devcontainer, Scriban, and xUnit compatibility for NuGet updates (#1967) * Port devcontainer and Scriban compatibility fixes from #1945 Keep the dependency updates from #1963 while adding PolySharp support and disabling Scriban generation limits. * Port xUnit v3 migration from #1797 Match Xunit.StaFact 4 with xunit.v3 4, retain VSTest and serial execution, and update output helpers and OS-specific facts. Remove the unused StaFact reference from the xUnit v2 Kubectl suite. --------- --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brendan Burns <5751682+brendandburns@users.noreply.github.com>

kubernetes-prow · 2026-10-17T06:50:39Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copilot

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

brendandburns · 2026-10-19T16:10:40Z

Closing, no longer needed.

Copilot AI balanced review requested due to automatic review settings October 14, 2026 04:12

kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2026

kubernetes-prow Bot requested a review from tg123 October 14, 2026 04:12

kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2026

Copilot started reviewing on behalf of brendandburns October 14, 2026 04:12

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2026

Update dependencies and devcontainer SDKs

21bec69

Copilot AI balanced review requested due to automatic review settings October 16, 2026 21:07

brendandburns force-pushed the deps/combined-updates-1932-1933-1934-1937 branch from 80011b5 to 21bec69 Compare October 16, 2026 21:07

Copilot started reviewing on behalf of brendandburns October 16, 2026 21:08

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2026

brendandburns mentioned this pull request Oct 17, 2026

Fix devcontainer, Scriban, and xUnit compatibility for NuGet updates #1967

Merged

kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2026

Merge branch 'master' into deps/combined-updates-1932-1933-1934-1937

a760661

Copilot AI balanced review requested due to automatic review settings October 19, 2026 16:10

Copilot AI reviewed Oct 19, 2026

View reviewed changes

kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2026

brendandburns closed this Oct 19, 2026

Navigation Menu

Repository navigation

Update dependencies and devcontainer SDKs - #1945

Update dependencies and devcontainer SDKs#1945
brendandburns wants to merge 2 commits into
kubernetes-client:masterfrom
brendandburns:deps/combined-updates-1932-1933-1934-1937

brendandburns commented Oct 14, 2026

Uh oh!

kubernetes-prow Bot commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

kubernetes-prow Bot commented Oct 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

brendandburns commented Oct 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

brendandburns commented Oct 14, 2026

Summary

Validation

Uh oh!

kubernetes-prow Bot commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

kubernetes-prow Bot commented Oct 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Oct 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants