Return uncategorized commands for a null category in GetCommandsByCategory [patch] - #158
Merged
Merged
Conversation
…egory [patch] A null CommandCategory converts to "" rather than null, so comparing it with string.Equals made GetCommandsByCategory(null) match nothing while "" and " " returned the uncategorized commands. Null, empty and whitespace now all select the uncategorized commands. Fixes #140 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019UNSUUrn4o84JfkEVaD3xg
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140
Problem
CommandRegistry.GetCommandsByCategorypassed theCommandCategory?tostring.Equals. A nullCommandCategoryconverts to"", notnull, sonullmatched nothing while""and" "matched the uncategorized commands.Change
ICommandRegistrydoc comment now says what a blank category means.string.Equalscalls on nullable SemanticStrings, as the triage suggested. There are none: the only other one compares a JSON property name.Tests
New
CommandCategoryFilterTests:null,""and" "each return onlyfile.save. Thenullrow fails onmain(expected 1, got 0) and passes with the fix."Edit","edit"and" Edit "each return onlyedit.copy.Categoryback in finds that command.The full suite passes locally: 141/141.
🤖 Generated with Claude Code
https://claude.ai/code/session_019UNSUUrn4o84JfkEVaD3xg
Generated by Claude Code