Repository navigation
Drop Core's stray Logging.Abstractions 11 reference so the Site builds again [patch] - #85
Open
matt-edmondson wants to merge 4 commits into
Open
matt-edmondson wants to merge 4 commits into
matt-edmondson wants to merge 4 commits into
Conversation
…s again [patch] Dependabot #81 bumped Microsoft.Extensions.Logging.Abstractions to 11.0.0 and added a direct reference to it in Core, which doesn't use it. The reference flowed into the Site and replaced the ASP.NET Core 10 shared-framework copy, so ktsu.Sdk failed the Site build with KTSU0006. Remove the reference, put the central version back to 10.0.0 to match the host and the framework, and keep Dependabot from proposing major bumps of Microsoft.Extensions.* on their own. Fixes #82 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4d7dbQrUhkrt4JoGT
Resolve Directory.Packages.props: take main's ktsu.Semantics.Strings 6.0.0 and keep this branch's Microsoft.Extensions.Logging.Abstractions 10.0.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5B3W6WRadY4oRm8a7
matt-edmondson
pushed a commit
that referenced
this pull request
Nov 11, 2026
Resolve Directory.Packages.props: take main's ktsu.Semantics.Strings 6.0.0 and keep Microsoft.Extensions.Logging.Abstractions 10.0.0 from #85. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5B3W6WRadY4oRm8a7
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW55E1qd6SA7hhzHqoF
…eeds [patch] main's MySqlConnector 3.0.0 depends on Microsoft.Extensions.Logging.Abstractions >= 10.0.15, so the 10.0.0 pin failed restore with NU1605. 10.0.15 stays on the .NET 10 line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW55E1qd6SA7hhzHqoF
matt-edmondson
added a commit
that referenced
this pull request
Nov 12, 2026
Takes main's MySqlConnector 3.0.0 and the 10.0.15 Logging.Abstractions pin from #85, the floor MySqlConnector 3.0.0 needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW55E1qd6SA7hhzHqoF
|
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
What was wrong
Dependabot #81 bumped
Microsoft.Extensions.Logging.Abstractionsto11.0.0centrally. It also added a directPackageReference ... VersionOverride="11.0.0"toCounterStrikeProgression.Core, which doesn't use the package. The reference flowed intoCounterStrikeProgression.Site, replaced the ASP.NET Core 10 shared-framework copy, and ktsu.Sdk failed the Site build with KTSU0006 (LiveState.cs(28,97),MetricsEndpoints.cs(22,38)). main has not built since.Change
Microsoft.Extensions.Logging.Abstractionsreference fromCounterStrikeProgression.Core.csproj.PackageVersionback to the .NET 10 line, to match the CounterStrikeSharp host and the ASP.NET Core 10 framework. The plugin keeps its compile-only reference (ExcludeAssets="runtime")..github/dependabot.yml: ignoreversion-update:semver-majorforMicrosoft.Extensions.*. Majors of these follow the target framework and shouldn't arrive one package at a time.Update: merged main (MySqlConnector 3.0.0)
main moved on with #92 (MySqlConnector 3.0.0), which conflicted in
Directory.Packages.props. The merge takes main's MySqlConnector 3.0.0. That version depends onMicrosoft.Extensions.Logging.Abstractions >= 10.0.15, so the original10.0.0pin then failed restore with NU1605 (package downgrade). The pin is now10.0.15, still on the .NET 10 line.Verification
2a7d412(main),dotnet buildfails with the two KTSU0006 errors in the Site.dotnet test --project CounterStrikeProgression.Test -c Releasereports 748 total: 741 passed, 7 MySQL tests skipped, 0 failed.ConVar. That is Plugin fails a Debug build with 6 × CS0618 since CounterStrikeSharp 1.0.379 madeConVarobsolete #83 (CounterStrikeSharp 1.0.379 obsoleting the untypedConVar), fixed separately in Read the game-mode and teammate cvars through the typed ConVar<T> API [patch] #86.This change has no unit test: the regression is in the package graph, and the build itself is what checks it.
Generated by Claude Code