Skip to content

fix(mcp): review findings: billing annotations, signing on create, hosted targetUrl, mcp 2.4.1 - #726

Merged
kroqdotdev merged 3 commits into
mainfrom
fix/mcp-review-findings
Nov 15, 2026
Merged

kroqdotdev merged 3 commits into
mainfrom
fix/mcp-review-findings

Conversation

@kroqdotdev

Copy link
Copy Markdown
Owner

Seven fixes to the MCP servers from an independent review, with the MCP 2.4.1 release.

Findings and fixes

  1. Billing tools were annotated as plain writes. change_plan, set_seats, change_addons, cancel_subscription and resume_subscription can charge the card or end a subscription through Polar, and once an agent budget is set some of them do it without asking. They now use a billing behaviour (destructive, openWorld); set_agent_budget is billing plus idempotent, and delete_team is remove plus openWorld (it ends the team's Polar subscription at once). catalog.test.ts pins the seven names, and a guard checks that every tool whose description carries BILLING_APPROVAL (now exported from tools.ts) is in that set.
  2. create_endpoint let Discord through without a key and returned the endpoint as it was before signing. signingSecret is now required whenever signingProvider is set (Discord's credential is the application's public key; the PATCH route refuses a provider without one), and the tool returns the PATCH result, which is the full endpoint with signingProvider and hasSigningSecret. If the update fails, the endpoint comes back with the warning as before. Both shapes describe the Discord key.
  3. The hosted server's instructions did not say how to load groups past the core. INSTRUCTIONS now explains ?tools=all and ?tools=core,teams. Tests check the text and that every name in TOOL_GROUP_NAMES parses through toolSelection. The MCP docs already had the ?tools= line.
  4. Captures of our own test sends kept the Worker's headers, and statusText was made up. The receiver reads a new OWN_WORKER_ZONES (comma separated, empty by default, documented in .env.example and config.rs). When a request's CF-Worker names one of those zones, CF-Worker and CF-EW-Via are dropped from the stored headers and from live relays (relay_headers). Rust tests cover a matching zone, a different zone and an empty list. In the MCP package, one helper (summarizeResponse) builds { status, statusText, body } for every tool that reports a response, and it leaves statusText out when the response had none. The hosted send_webhook description says it is sent from webhooks.cc's network, so the capture shows a Cloudflare address.
  5. The hosted server listed targetUrl and then refused it. On the hosted server, render_email and test_webhook_flow are now registered without targetUrl, and their descriptions no longer mention it. A test in hosted-app.test.ts sends targetUrl anyway: the adapter's z.object(shape) drops it, and nothing is posted there. The refusal could no longer be reached, so it is deleted. The local server still lists targetUrl (tools.test.ts). The docs, README and skill now say "no targetUrl" instead of "refused", and the bundled skill copy is regenerated.
  6. The local server's instructions pointed at enable_tools even for clients that never get it. They now say that when enable_tools is not listed, every group is already loaded. groups.test.ts asserts this.
  7. The hosted server reported the web app's version. It now reports MCP_VERSION. The web version stays in its User-Agent. A test reads the server identity from server/discover.

The server-level hosted tests (version, schemas, the dropped targetUrl) are in hosted-app.test.ts, next to the existing harness that builds a hosted server. The pure ones are in hosted.test.ts.

Release

  • MCP 2.4.1: packages/mcp/package.json, both version fields in packages/mcp/server.json, and MCP_VERSION with an MCP-track changelog entry.
  • Web changelog file: apps/web/changelog/web/mcp-review-fixes.json.

Ops step

Set OWN_WORKER_ZONES on the production receiver to the notify proxy Worker's zone. Keep the value in the ops repository, not here. Until it is set, nothing changes: the default list is empty.

Checks

pnpm typecheck, pnpm lint and pnpm test (SDK, MCP and web unit suites, including the hosted MCP tests) all pass. cargo fmt, cargo clippy --all-targets -- -D warnings and cargo test in apps/receiver-rs pass (373 tests). Prettier was run on the changed files.

🤖 Generated with Claude Code

…sted targetUrl, mcp 2.4.1

- Billing tools (change_plan, set_seats, change_addons, cancel_subscription,
  resume_subscription, set_agent_budget) and delete_team are annotated
  destructive and open-world: each can charge or end a Polar subscription,
  some without asking once an agent budget is set. A test keeps every tool
  that asks for a billing approval in that set.
- create_endpoint needs signingSecret for every signing provider (Discord's
  application public key too) and returns the endpoint as the update saved it.
- The hosted server leaves targetUrl out of render_email and
  test_webhook_flow (schema and descriptions); its z.object drops one sent
  anyway, so the refusal that could no longer be reached is gone.
- Tool results leave statusText out when the response carried none; the
  hosted send_webhook says it sends from webhooks.cc's network.
- The hosted server reports MCP_VERSION and its instructions explain
  ?tools=; the local server's instructions say that without enable_tools
  every group is already loaded.
- Receiver: OWN_WORKER_ZONES (empty by default) drops CF-Worker and
  CF-EW-Via from captures and live relays when the Worker is our own.
- Release: MCP 2.4.1 with its changelog entry, and a web changelog file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kroqdotdev kroqdotdev added the release: patch Ships a fix or small feature: the next web release bumps the patch version label Nov 15, 2026
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ec7ba6b9-cb22-470e-b776-352098d56d8b
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@kroqdotdev

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Action not completed

Head commit changed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

kroqdotdev and others added 2 commits November 15, 2026 22:23
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kroqdotdev
kroqdotdev merged commit 23f63f0 into main Nov 15, 2026
37 checks passed
@kroqdotdev
kroqdotdev deleted the fix/mcp-review-findings branch November 15, 2026 21:39
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release: patch Ships a fix or small feature: the next web release bumps the patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant