Skip to content

Fix Kptfile pipeline not updating on pkg update with fast-forward/force-delete-replace - #4704

Open
OisinJohnston2005 wants to merge 10 commits into
kptdev:mainfrom
Nordix:pkg-update-not-updating-kptfile
Open

Fix Kptfile pipeline not updating on pkg update with fast-forward/force-delete-replace#4704
OisinJohnston2005 wants to merge 10 commits into
kptdev:mainfrom
Nordix:pkg-update-not-updating-kptfile

Conversation

@OisinJohnston2005

Copy link
Copy Markdown
Contributor

Fixes #4012

With test cases taken from #4030

Instead of performing a three way merge the KPT file is directly updated from upstream when using strategies that should not respect local changes like fast-forward and force-delete-replace, allowing the upstream to update the pipeline.

@netlify

netlify Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 0c35ce3
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a86eeed5a461a0008269af0
😎 Deploy Preview https://deploy-preview-4704--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working go Pull requests that update Go code labels Aug 17, 2026
@efiacor efiacor closed this Aug 20, 2026
@efiacor efiacor reopened this Aug 20, 2026
michaelvl and others added 9 commits August 20, 2026 12:32
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
@OisinJohnston2005
OisinJohnston2005 force-pushed the pkg-update-not-updating-kptfile branch from e1ee784 to 6b17844 Compare August 20, 2026 11:34
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
76.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@OisinJohnston2005

OisinJohnston2005 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

SonarQube is only complaining because it's still including testutil.go - a test file, in its test coverage tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kpt: pkg update fails to update Kptfile

3 participants