Skip to content

fix(workflow): preserve WorkWX approval node details - #4977

Merged
leozhang2018 merged 4 commits into
koderover:mainfrom
Cynthia-0203:fix/workwx-approval-node-details
Sep 15, 2026
Merged

leozhang2018 merged 4 commits into
koderover:mainfrom
Cynthia-0203:fix/workwx-approval-node-details

Conversation

@Cynthia-0203

@Cynthia-0203 Cynthia-0203 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

What this PR does / Why we need it:

Fixes missing approval_node_details for WorkWX approval jobs after approval status handling switched to active polling.

What is changed and how it works?

Parses approval records from the WorkWX approval detail response, converts them to the existing approval node structure, and persists them only when the details change.

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

This change is Reviewable

Signed-off-by: Cynthia <chenchen@koderover.com>
Signed-off-by: Cynthia <chenchen@koderover.com>
@landylee007
landylee007 requested a review from PetrusZ September 11, 2026 12:23
Signed-off-by: Cynthia <chenchen@koderover.com>
Signed-off-by: Cynthia <chenchen@koderover.com>
@leozhang2018
leozhang2018 merged commit 608968d into koderover:main Sep 15, 2026
4 checks passed
leozhang2018 added a commit that referenced this pull request Sep 15, 2026
…tails-release-5.0.0

cp: cherry pick #4977 to release 5.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants