fix: preserve YAML template variable metadata on update - #4973
Merged
leozhang2018 merged 2 commits intoSep 15, 2026
Merged
leozhang2018 merged 2 commits into
leozhang2018 merged 2 commits into
Conversation
Signed-off-by: Cynthia <chenchen@koderover.com>
Cynthia-0203
force-pushed
the
fix/template-library-render-validation
branch
from
September 10, 2026 02:38
64e55c0 to
97fd70e
Compare
Signed-off-by: Cynthia <chenchen@koderover.com>
PetrusZ
approved these changes
Sep 14, 2026
leozhang2018
added a commit
that referenced
this pull request
Sep 15, 2026
…-validation-release-5.0.0 cp: cherry pick #4973 to release 5.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Fixes YAML template variable updates incorrectly resetting frontend-defined metadata, such as
enumtypes and options, tostring.What is changed and how it works?
Separates variable validation from metadata handling:
service_variable_kvspreserves type, options, and description.variable_yamlare still cleaned up.Does this PR introduce a user-facing change?
This change is