Skip to content

feat(workflow): add execution input OpenAPIs - #4970

Merged
leozhang2018 merged 16 commits into
koderover:mainfrom
huanghongbo-hhb:feat/workflow-run-input-openapi
Sep 16, 2026
Merged

leozhang2018 merged 16 commits into
koderover:mainfrom
huanghongbo-hhb:feat/workflow-run-input-openapi

Conversation

@huanghongbo-hhb

@huanghongbo-hhb huanghongbo-hhb commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Enable CLI workflow preparation and repository ref selection through OpenAPI.

Main Changes

  • Preserve workflow execution preset values; normalize code source fields required by CLI queries.
  • Support runtime inputs and reject invalid repository modes, unknown Job targets, and unselected fromjob deploy sources.
  • Replace CLI-dependent internal codehost queries with OpenAPI endpoints.

Compatibility / Test

  • Internal codehost APIs and legacy workflow/release-plan callers retain prior behavior.
  • go test ./pkg/microservice/aslan/core/code/... passed.
  • Workflow package compiles with go test -vet=off -run '^$'; full tests remain blocked by unrelated existing vet issues.
  • No test files or documentation are included in the PR.
    Contact: huanghongbo@koderover.com

This change is Reviewable

Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Keep the OpenAPI implementation in the PR without the accompanying unit tests.

Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
huanghongbo-hhb force-pushed the feat/workflow-run-input-openapi branch from ccf59c1 to 23adec5 Compare September 8, 2026 06:03
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@github-actions github-actions Bot added the common label Sep 9, 2026
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Comment thread pkg/microservice/aslan/core/code/service/branch.go Outdated
Comment thread pkg/microservice/aslan/core/workflow/handler/openapi.go
Comment thread pkg/microservice/aslan/core/workflow/handler/openapi.go
@lilianzhu

Copy link
Copy Markdown
Collaborator

Zadig AI Review

⚠️ 审查未完整完成

  • 审查范围:origin/mainpr4970
  • 变更文件:18
  • Findings:3
  • 模型:glm-5.3
  • 严重级别:critical 0 / high 0 / medium 2 / low 1
  • 行内评论:3 / 3

所有 finding 均已发布为行内评论。

Errors

  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/client/interface.go" agent_source="internal/reviewer/agent_loop.go:230" round=4 request_attempts=2 duration=6m0.505s configured_timeout=3m0s review_concurrency=4 message_count=13 tools="task_done,code_comment" require_tool=true estimated_tokens=8385 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/service/merge_request.go" agent_source="internal/reviewer/agent_loop.go:230" round=4 request_attempts=2 duration=6m0.503s configured_timeout=3m0s review_concurrency=4 message_count=12 tools="task_done,code_comment" require_tool=true estimated_tokens=7114 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/handler/router.go" agent_source="internal/reviewer/agent_loop.go:230" round=4 request_attempts=2 duration=6m0.509s configured_timeout=3m0s review_concurrency=4 message_count=12 tools="task_done,code_comment" require_tool=true estimated_tokens=8818 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/service/tag.go" agent_source="internal/reviewer/agent_loop.go:230" round=4 request_attempts=2 duration=6m0.502s configured_timeout=3m0s review_concurrency=4 message_count=13 tools="task_done,code_comment" require_tool=true estimated_tokens=7079 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • llm request failed (stage=review file="pkg/types/openapi.go" agent_source="internal/reviewer/agent_loop.go:230" round=4 request_attempts=2 duration=6m0.502s configured_timeout=3m0s review_concurrency=4 message_count=11 tools="task_done,code_comment" require_tool=true estimated_tokens=9035 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Warnings

  • token_threshold_exceeded: pkg/microservice/aslan/core/code/handler/codehost.go
  • token_threshold_exceeded: pkg/microservice/aslan/core/workflow/handler/router.go
  • finding_localization_failed: localized content is incomplete for c-0
  • token_threshold_exceeded: pkg/microservice/aslan/core/workflow/service/workflow/openapi.go
  • plan_failed: pkg/microservice/aslan/core/workflow/service/workflow/types.go: llm request failed (stage=plan file="pkg/microservice/aslan/core/workflow/service/workflow/types.go" agent_source="internal/reviewer/agent_loop.go:92" attempt=1 request_attempts=2 duration=6m0.503s configured_timeout=3m0s review_concurrency=4 message_count=2 tools="" require_tool=false estimated_tokens=9264 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • token_threshold_exceeded: pkg/microservice/aslan/core/workflow/service/workflow/types.go

Comment thread pkg/microservice/aslan/core/workflow/testing/service/types.go
@lilianzhu

Copy link
Copy Markdown
Collaborator

Zadig AI Review

⚠️ 审查未完整完成

  • 审查范围:origin/mainpr4970
  • 变更文件:18
  • Findings:1
  • 模型:glm-5.3
  • 严重级别:critical 0 / high 0 / medium 0 / low 1
  • 行内评论:1 / 1

所有 finding 均已发布为行内评论。

Errors

  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/service/branch.go" agent_source="internal/reviewer/agent_loop.go:230" round=4 request_attempts=2 duration=6m0.507s configured_timeout=3m0s review_concurrency=4 message_count=13 tools="task_done,code_comment" require_tool=true estimated_tokens=7561 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/handler/router.go" agent_source="internal/reviewer/agent_loop.go:230" round=4 request_attempts=2 duration=6m0.503s configured_timeout=3m0s review_concurrency=4 message_count=13 tools="task_done,code_comment" require_tool=true estimated_tokens=9166 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/service/merge_request.go" agent_source="internal/reviewer/agent_loop.go:230" round=3 request_attempts=2 duration=6m0.505s configured_timeout=3m0s review_concurrency=4 message_count=8 tools="task_done,code_comment,file_read,code_search,changed_diff_read,file_find" require_tool=true estimated_tokens=7760 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
  • llm request failed (stage=review file="pkg/microservice/aslan/core/code/handler/codehost.go" agent_source="internal/reviewer/agent_loop.go:230" round=5 request_attempts=2 duration=6m0.506s configured_timeout=3m0s review_concurrency=4 message_count=16 tools="task_done,code_comment" require_tool=true estimated_tokens=8061 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Warnings

  • token_threshold_exceeded: pkg/microservice/aslan/core/workflow/handler/router.go
  • token_threshold_exceeded: pkg/microservice/aslan/core/workflow/service/workflow/openapi.go
  • token_threshold_exceeded: pkg/microservice/aslan/core/workflow/service/workflow/types.go
  • plan_failed: pkg/microservice/aslan/core/code/handler/codehost.go: llm request failed (stage=plan file="pkg/microservice/aslan/core/code/handler/codehost.go" agent_source="internal/reviewer/agent_loop.go:92" attempt=1 request_attempts=2 duration=6m0.509s configured_timeout=3m0s review_concurrency=4 message_count=2 tools="" require_tool=false estimated_tokens=2798 protocol=openai model="glm-5.3"): Post "https://ark.cn-beijing.volces.com/api/plan/v3/chat/completions": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@github-actions github-actions Bot removed the common label Sep 15, 2026
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@leozhang2018
leozhang2018 merged commit 2e09575 into koderover:main Sep 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants