Skip to content

ci: stop releases failing on issue references they cannot resolve - #202

Merged
tkuhn merged 1 commit into
mainfrom
fix-release-issue-comment
Aug 24, 2026
Merged

ci: stop releases failing on issue references they cannot resolve#202
tkuhn merged 1 commit into
mainfrom
fix-release-issue-comment

Conversation

@tkuhn

@tkuhn tkuhn commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

The 1.27.1 release job exited 1 after the release had already shipped.

What happened

@semantic-release/github's success step resolves every issue reference in the released commits and comments on it — but it looks each number up in this repo, dropping any owner/repo qualifier. My commit message for #201 cited eclipse-rdf4j/rdf4j#4775, which became a lookup for knowledgepixels/nanopub-query#4775:

Failed step "success" of plugin "@semantic-release/github"
Error: Could not resolve to an issue or pull request with the number of 4775.
  type: 'NOT_FOUND', path: [ 'repository', 'issue4775' ]

Everything of substance had already completed by then — tag nanopub-query-1.27.1, the GitHub release, and Built and pushed image as nanopub/query, nanopub/query:1.27.1. The only casualty was the workflow's final "Update main branch after release" step, which never ran and left main two commits behind release (no changelog entry, stale snapshot version). That has been repaired by merging release into main; a re-run would not have fixed it, since with the tag present semantic-release finds nothing releasable and skips past.

The change

successCommentCondition: false on the github plugin. The guard in the plugin's success.js wraps the entire resolution block, so the failing GraphQL lookup never happens and no future upstream reference can take a release down with it.

This repo cites rdf4j issues constantly, so the next stray #N was a matter of time — worth removing the hazard rather than policing commit messages.

Deliberately kept: failure reporting (failComment/failTitle), which opens an issue in this repo and cannot hit the same lookup. Also unaffected is the changelog, which renders cross-repo references correctly — the 1.27.1 entry links eclipse-rdf4j/rdf4j#4775 to the right repository. Only the commenting step has this defect.

Verified the config parses with the plugin list intact and exactly one @semantic-release/github entry:

@semantic-release/commit-analyzer -> @semantic-release/release-notes-generator ->
@semantic-release/changelog -> @terrestris/maven-semantic-release ->
@semantic-release/github -> @semantic-release/git

🤖 Generated with Claude Code

The github plugin's success step resolves every issue reference in the released
commits and comments on it, but it looks each number up in THIS repo and drops
any owner/repo qualifier. Commit messages here routinely cite upstream rdf4j
issues, so a reference to eclipse-rdf4j/rdf4j#4775 became a lookup for
knowledgepixels/nanopub-query#4775 and the release job exited 1:

  Failed step "success" of plugin "@semantic-release/github"
  Error: Could not resolve to an issue or pull request with the number of 4775.

By then the release had already completed — tag nanopub-query-1.27.1, the GitHub
release, and "Built and pushed image as nanopub/query:1.27.1" — so the only
casualty was the workflow's final "Update main branch after release" step, which
never ran and left main without the release commit and the snapshot bump (fixed
separately by merging release into main). A re-run would not have repaired it
either: with the tag already present semantic-release finds nothing releasable
and skips straight past.

successCommentCondition:false skips the resolution entirely (the guard in the
plugin's success.js wraps the whole block), so no future upstream reference can
take a release down with it. Failure reporting stays on: it opens an issue in
this repo and cannot hit the same lookup.

The changelog renders cross-repo references correctly either way — the entry for
1.27.1 links eclipse-rdf4j/rdf4j#4775 to the right repository. Only the
commenting step has this defect.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@tkuhn
tkuhn merged commit 939bd90 into main Aug 24, 2026
8 checks passed
@tkuhn
tkuhn deleted the fix-release-issue-comment branch August 24, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant