feat: surface introduced-but-unapproved users as pending (#625) - #637
Merged
Conversation
Users who had published an introduction but were not trust-approved yet were invisible: their self-signed participation roles showed up nowhere, and view displays they published for their own profile page never rendered. nanopub-query now materializes such accounts as npa:PendingAccountState rows and validates their observer-tier self-assignments, stamped npa:trustStatus npa:seen (nanopub-query#195). This picks that up on the nanodash side: - get-view-displays superseded (RA3ekD-2, source in docs/queries/): the authority gate's own-page arm additionally accepts pending-account rows, so an unapproved user's own page shows the view displays they signed themselves. Display-only: the pending class is distinct from npa:AccountState, so the admin/maintainer arm and governed-version resolution keep requiring approved accounts. Validated byte-identical to the previous version across approved resources. - list-space-observers superseded (RARcL1s1, source in docs/queries/): the headerless flag column becomes three-state — empty for approved-validated, ⏳ for pending-validated,⚠️ for not validated at all — so self-signed-up members awaiting approval are listed but visibly distinct. - A third title-bar message box tells users with an introduction but no approved key that their account is pending and their contributions show as pending (⏳) until an approved user approves their introduction. Users with an approved key elsewhere are excluded — their local-key situation is covered by the About-page recommendations. Both superseding queries are published; the constants pin the new heads. Closes #625 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop the "contributions are marked as pending" clause — whether pending contributions are marked depends on the individual queries/views, so it is not generally true. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 5.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #625. Companion to knowledgepixels/nanopub-query#195 (
npa:PendingAccountStatematerialization, deployed): introduced-but-unapproved users were invisible — their self-signed participation roles showed up nowhere, and view displays they published for their own profile never rendered.Changes
get-view-displayssuperseded →RA3ekD-2utY7…(source:docs/queries/get-view-displays-pending-arm.trig): the authority gate's own-page arm additionally acceptsnpa:PendingAccountStaterows, so an unapproved user's own page shows the view displays they signed themselves. Display-only — the pending class is distinct fromnpa:AccountState, so the admin/maintainer arm and governed-version resolution keep requiring approved accounts. Validated byte-identical to the previous head across approved resources.list-space-observerssuperseded →RARcL1s1A1Fi…(source:docs/queries/list-space-observers-ref-v7.trig): headerless flag column is now three-state — empty = approved-validated, ⏳ = pending-validated (npa:trustStatus npa:seenon the materialized instantiation),Both superseding queries are published; the
QueryApiAccessconstants pin the new heads, so this is safe to deploy any time.Verified
spaces/knowledgepixels/ko2025lecture9appear ⏳-flagged in the published observers query; approved members unchanged.group_concatordering) to their predecessors on approved resources/spaces.🤖 Generated with Claude Code