fix(registry): parse-integrity invariants + honest staleness (#68) - #87
Merged
Conversation
Addresses the #68 correctness findings from the external review of PR #81. - **registry.mjs** parseRegistryFile now enforces the identity invariants it skipped: every asset's kind must match the file's kind (no test-case in the product-use-case file), IDs are unique within a file, and a canonical asset must carry its content-hash revision (in addition to the existing revision-match check). - **staleness.mjs** missing comparison evidence is no longer reported as covered: a bound axis with no current revision is `unknown` (not `covered`), and a result that bound nothing is `uncovered`. Only a full set of matching bound/current revisions is `covered`. - Tests for kind-mismatch / duplicate-id / missing-revision and for unknown/uncovered staleness; corrected the prior test that encoded the false-covered behavior. Relates to #68. Resolves the PR #81 registry and staleness threads. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwyFyRC6pepaK6DuMK7YeT
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth fix off the 3.0 audit — #68 correctness.
unknown, and an empty binding isuncovered; only fully-matched revisions arecovered(previously a bound axis with no current revision falsely readcovered).28 registry tests; full suite + generated-drift green. Base
3.0. Resolves the PR #81 registry and staleness threads.Relates to #68