Update go-git/v5 to latest release - #4050
Conversation
|
@dsimansk: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
approved
| return fmt.Errorf("failed to get worktree: %w", err) | ||
| } | ||
| fs = filesystem.NewBillyFilesystem(wt.Filesystem) | ||
| fs = filesystem.NewOsFilesystem(tempDir) |
There was a problem hiding this comment.
@matejvasek PTAL, this is necessary change because of worktree hardening in go-git. It no longer allow .git to be .CopyFromFS later in the function. The change keeps the intention to copy the whole repo content with .git and its metadata preserved.
1 participant
Changes
/kind
Fixes #
Release Note
Maintenance and trying to verify it's working without additional changes for midstream purposes.
/cc @matejvasek @gauron99