Skip to content

chore: remove the tkn-tasks subcommand #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gauron99 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove the tkn-tasks subcommand #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ Learn more about Knative at: https://knative.dev`, cfg.Name),
Commands: []*cobra.Command{
NewCompletionCmd(),
NewVersionCmd(cfg.Version),
NewTektonClusterTasksCmd(),
NewMCPCmd(newClient),
},
},
Expand Down
27 changes: 0 additions & 27 deletions cmd/tkn_tasks.go
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions pkg/pipelines/tekton/tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package tekton
import (
"bytes"
_ "embed"
"strings"
"text/template"
)

Expand Down Expand Up @@ -38,14 +37,6 @@ func getS2ITask() string {
return getTask(s2iTaskTemplate)
}

// GetClusterTasks returns multi-document yaml containing tekton tasks used by func.
func GetClusterTasks() string {
tasks := getBuildpackTask() + "\n---\n" + getS2ITask()
tasks = strings.ReplaceAll(tasks, "kind: Task", "kind: ClusterTask")
tasks = strings.ReplaceAll(tasks, "apiVersion: tekton.dev/v1", "apiVersion: tekton.dev/v1beta1")
return tasks
}

func getTask(t string) string {
tmpl, err := template.New("").Parse(t)
if err != nil {
Expand Down
Loading