Fix RequestReply duplicate reply deadlock#9191
Conversation
|
Welcome @rootp1! It looks like this is your first PR to knative/eventing 🎉 |
|
Hi @rootp1. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rootp1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Cali0707, please have a look, whenever you have a chance to |
Fixes #9190
Proposed Changes
Pre-review Checklist
Current local run:
go test -cover ./pkg/requestreplyreported77.1%statement coverage forpkg/requestreply. This PR adds a focused regression test, but does not yet bring the package above the template target on its own.Not applicable for this change as implemented in this PR. The fix is confined to the in-process RequestReply handler concurrency path, and the regression is covered with a focused unit test in
pkg/requestreply/ingress_handler_test.go.Not applicable. This is an internal reliability fix with no user-facing API, CLI, or workflow change.
Not applicable. No API surface or behavior contract is being extended.
Not applicable. There is no spec change in this PR.
Release Note
Docs
No docs update required; this is an internal reliability fix with no API or user workflow change.