Ci updates#448
Closed
evelikov wants to merge 3 commits into
Closed
Conversation
Ubuntu 26.04 is the first version to include mbedtls v3. Add it to the build and update the runners to it. Getting us a step closer to having a) formal code coverage for that path and b) knowing what fixes we'll need once the runner is out of "preview". Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
With codecov v5, their release note states (et al):
The following arguments have been changed
- `file` (this has been deprecated in favor of `files`)
Where they actually meant _removed_... Oopsie :-)
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
The default has changed with codecov v5, where all existing plugins are
attempted. In practise we only need gcov, which seems to work file.
Specify it, saving us the following warning:
coverage.py is not installed or can't be found.
Initially I tried adding it to the Ubuntu image, only to notice they
lack the looked for `coverage.py` executable and instead have
`python{version.minor}-coverage.py`.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
lucasdemarchi
pushed a commit
that referenced
this pull request
Jul 6, 2026
Ubuntu 26.04 is the first version to include mbedtls v3. Add it to the build and update the runners to it. Getting us a step closer to having a) formal code coverage for that path and b) knowing what fixes we'll need once the runner is out of "preview". Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #448 Signed-off-by: Lucas De Marchi <ldemarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Jul 6, 2026
With codecov v5, their release note states (et al):
The following arguments have been changed
- `file` (this has been deprecated in favor of `files`)
Where they actually meant _removed_... Oopsie :-)
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: #448
Signed-off-by: Lucas De Marchi <ldemarchi@kernel.org>
lucasdemarchi
pushed a commit
that referenced
this pull request
Jul 6, 2026
The default has changed with codecov v5, where all existing plugins are
attempted. In practise we only need gcov, which seems to work file.
Specify it, saving us the following warning:
coverage.py is not installed or can't be found.
Initially I tried adding it to the Ubuntu image, only to notice they
lack the looked for `coverage.py` executable and instead have
`python{version.minor}-coverage.py`.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: #448
Signed-off-by: Lucas De Marchi <ldemarchi@kernel.org>
Contributor
|
Applied, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few commits inspired while looking at the code coverage action, namely:
codecov action warns about missing python-coverage, even though it should (tm) be using gcovexplicitly specifygcovas the only plugin - moar codecov v5 "deprecation" snafufile, which they listed as "changed" and "deprecated" 😛Hope this is enough to get it working reliably 🤞 since the alternative might be a bug in their server code.