Skip to content

Add scheme property to Spoolman to support instances behind https#271

Open
ross wants to merge 4 commits into
klaasnicolaas:mainfrom
ross:scheme-param
Open

Add scheme property to Spoolman to support instances behind https#271
ross wants to merge 4 commits into
klaasnicolaas:mainfrom
ross:scheme-param

Conversation

@ross

@ross ross commented Feb 13, 2026

Copy link
Copy Markdown

Proposed change

My Spoolman instance runs in docker and is only reachable via https. This PR adds a new scheme property, defaulting to http, and passes it in to URL.build.

Additional information

Had a bit of a time finding a way to verify that https was actually passed through during the test. Lmk if you have cleaner suggestions there.

Checklist

  • I have updated the documentation if needed.
  • I have updated the tests if needed.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 16, 2026
@klaasnicolaas klaasnicolaas added no-stale This issue or PR is exempted from the stable bot. and removed stale There has not been activity on this issue or PR for quite some time. labels Mar 16, 2026
@klaasnicolaas klaasnicolaas self-assigned this Mar 16, 2026
@klaasnicolaas klaasnicolaas added the new-feature New features or request. label May 18, 2026
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f5081c3) to head (d73169c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          134       135    +1     
  Branches         4         4           
=========================================
+ Hits           134       135    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New features or request. no-stale This issue or PR is exempted from the stable bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants