Conversation
- Pin actions/checkout, cache, upload-artifact, download-artifact to commit SHA - Replace manual submodule steps with actions/checkout submodules option - Remove unused submodule.ps1 - Drop unnecessary apk upgrade and manual safe.directory setup
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughLinux CI matrix split into ChangesCI Workflow pinning and checkout refactor
Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant actions_checkout as actions/checkout
participant setup_php as shivammathur/setup-php
participant apt_get as apt-get
GitHubActions->>actions_checkout: checkout (persist-credentials:false, set-safe-directory, submodules conditional)
GitHubActions->>setup_php: run with matrix.php and env.phpts (matrix.ts), extensions (xml,mbstring, optional apcu)
setup_php->>apt_get: (when matrix.library) install libzstd-dev
GitHubActions->>GitHubActions: run tests with Makefile option -d extension=apcu.so (when matrix.apcu)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0803488 to
3b31ca1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/linux.yaml:
- Around line 67-72: The workflow step "Install PHP APCu extension" uses pie
which requires PHP >= 8.1 and will fail for matrix entries with PHP 7.x; update
the workflow so both the "Install PHP APCu extension" step and the related "Test
Preparation APCu" step are gated by a condition that checks PHP >= 8.1 (e.g.,
use if: ${{ matrix.apcu && matrix.php >= '8.1' }}) or implement a conditional
install path: when matrix.php < '8.1' use PECL to install apcu and when
matrix.php >= '8.1' use pie, referencing the step names "Install PHP APCu
extension" and "Test Preparation APCu" to locate and change the condition or
install logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f24a0004-e162-470a-b2c5-6cc6541dc7af
📒 Files selected for processing (1)
.github/workflows/linux.yaml
ed560ad to
d7a8797
Compare
Replace the Alpine PHP container matrix with shivammathur/setup-php running directly on ubuntu-latest: - Add a `ts` axis (nts/zts) and consolidate PHP 7.0-8.5 into a single version list - Install zstd via apt (libzstd-dev) instead of apk (zstd-dev) - Install APCu through setup-php extensions instead of pecl install - Set fail-fast: false
Summary by CodeRabbit