Repository navigation
Add dedicated permission for TTW blocks configuration - #139
Merged
Merged
Conversation
Change the `blocks_config_mutator` write permission from `kitconcept.intranet.siteadminsonly` to the new dedicated `kitconcept.can_edit_blocks_config` permission. Register upgrade step v20260918001 that grants the permission to Manager and Site Administrator on existing sites, and add the same mapping to the base rolemap.xml for fresh installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces a dedicated permission,
kitconcept.can_edit_blocks_config("Can edit TTW blocks configuration"), for theblocks_config_mutatorfield write permission, replacingkitconcept.intranet.siteadminsonly.Changes
blocks_settings.pynow useskitconcept.can_edit_blocks_configas the write permission forblocks_config_mutator.permissions.zcml.v20260918001:update_blocks_config_permissiongrants the permission toManagerandSite Administratoron existing sites (source20260917001→ destination20260918001); registered inupgrades/configure.zcmland the base profile bumped inmetadata.xml.profiles/base/rolemap.xml(acquire="False").test_update_blocks_config_permissionwhich runs the handler and asserts the permission maps toManagerandSite Administrator; updated thecurrent_versions.basefixture and the upgrade-path parametrization.Testing
uv run pytest tests/setup/test_upgrades.py— 16 passed, including the new handler test.