fix(keyboard): stack page up and page down labels - #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render Home and End as centered text labels and stack Page Up / Page Down onto two centered lines so the Apple-sized keycaps fit the full legend.
Tests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'xcodebuild build -project Keyty.xcodeproj -scheme Keyty -configuration DebugUI Changes
Attach screenshots or screen recordings for visible UI changes. Write if there are none.
Documentation
Release Notes
Keyboard visualizer labels for Home, End, Page Up, and Page Down now render as readable text, with Page Up and Page Down stacked across two lines to fit the keycap.