change(web): remove .preservationTransform, .taillessTrueKeystroke 🔪#16072
Open
jahorton wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
web/
web/predictive-text/
change
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
change/web/remove-unused-transition-edit-field
branch
from
3948c1d to
82b9f18
Compare
jahorton
force-pushed
the
change/web/remove-preservation-transform
branch
from
147505d to
b582cb6
Compare
jahorton
force-pushed
the
change/web/remove-unused-transition-edit-field
branch
from
82b9f18 to
0b97139
Compare
jahorton
force-pushed
the
change/web/remove-preservation-transform
branch
from
b582cb6 to
864ed0d
Compare
Now that much of the infrastructure for handling boundary-correction is in place, we have improved techniques for ensuring that text before the current token is maintained when applying suggestions. Furthermore, the old techniques being removed were based on the assumption of there being "one true tokenization" - an assumption that will soon be _very_ much invalid. These will get in the way if we maintain them any longer, and so it is a good time to remove them. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
change/web/remove-unused-transition-edit-field
branch
from
0b97139 to
c2816da
Compare
jahorton
force-pushed
the
change/web/remove-preservation-transform
branch
from
864ed0d to
bbce66b
Compare
ermshiperete
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that much of the infrastructure for handling boundary-correction is in place, we have improved techniques for ensuring that text before the current token is maintained when applying suggestions. We can correct past just the token closest to the text insertion point; such corrections are what
.preservationTransformand.taillessTrueKeystrokeoriginally existed to support and model!Furthermore, the old techniques being removed were based on the assumption of there being "one true tokenization" - an assumption that will soon be very much invalid. These will get in the way if we maintain them any longer, and so it is a good time to remove them.
Build-bot: skip build:web
Test-bot: skip