refactor(web): define common buildCorrectionSequence method used for all model types 🔪#16028
Open
jahorton wants to merge 1 commit into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
Bot
added
web/
web/predictive-text/
and removed
epic-boundary-correction
labels
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
change/web/abstract-whitespace-tokenization-mapping
branch
from
6374711 to
9c13347
Compare
jahorton
force-pushed
the
refactor/web/correction-sequence-construction
branch
2 times, most recently
from
bc3691e to
b6ba677
Compare
jahorton
force-pushed
the
refactor/web/correction-sequence-construction
branch
from
b6ba677 to
0e52f6f
Compare
jahorton
force-pushed
the
change/web/abstract-whitespace-tokenization-mapping
branch
from
9c13347 to
8d52ba4
Compare
…all model types Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/correction-sequence-construction
branch
2 times, most recently
from
e789e1b to
e76b338
Compare
Contributor
|
I think the PR referenced in the description has the wrong number (#15841). |
ermshiperete
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To better handle inputs that shift the word-boundary in some custom models and models released before Keyman 14.0, this PR provides generalized re-use of the correction-sequence construction algorithm (introduced in #15841). The implementation from #15841 may only be used for our most prominently-supported models, but with a small tweak, it can be made much more useful for custom and legacy models as well, DRYing out this aspect of the code.
Build-bot: skip build:web
Test-bot: skip