refactor(web): expose suggestion-root parameters for use in unit tests 🚂 🔪#15977
Open
jahorton wants to merge 2 commits into
Open
refactor(web): expose suggestion-root parameters for use in unit tests 🚂 🔪#15977jahorton wants to merge 2 commits into
jahorton wants to merge 2 commits into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
change/web/simplify-predict-calls
branch
from
8db8f32 to
4d2a037
Compare
jahorton
force-pushed
the
refactor/web/expose-suggestion-root-tokenization
branch
from
3227268 to
1368431
Compare
jahorton
force-pushed
the
refactor/web/expose-suggestion-root-tokenization
branch
from
1368431 to
e1ed99c
Compare
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
change/web/simplify-predict-calls
branch
from
c976b9d to
e9d2ea2
Compare
jahorton
force-pushed
the
refactor/web/expose-suggestion-root-tokenization
branch
2 times, most recently
from
cc29030 to
b576c93
Compare
jahorton
force-pushed
the
change/web/simplify-predict-calls
branch
from
4538c28 to
84d00f7
Compare
Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/expose-suggestion-root-tokenization
branch
from
b576c93 to
fe6acfd
Compare
…pose-suggestion-root-tokenization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #15851 reworks prediction to use sequences of corrections as correction roots, this PR reworks related methods just enough to allow unit testing to verify the behavior of methods that build sequences of corrections for use in prediction.
Build-bot: skip build:web
Test-bot: skip