chore: verify bootstrap version format before merge#794
Merged
Conversation
It is important that the bootstrap version is pointing to a published tag, so that merged changes do not end up pointing to an ephemeral ref on the shared-sites repository. This change splits the bootstrap version into a separate file resources/.bootstrap-required-version, so that this version string can be easily checked in ci.yml, preventing merge of pull requests that point to branch names instead of tag names. For simplicity, the test verifies the shape of the version string as 'v#.#.#', but does not verify that it actually points to a tag, so in theory it could be fooled, but in practice we never use that pattern for branch names. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
requested review from
darcywong00 and
ermshiperete
and removed request for
ermshiperete
darcywong00
reviewed
Jun 16, 2026
| @@ -0,0 +1 @@ | |||
| feat/linkinator-and-central-test-script No newline at end of file | |||
Contributor
There was a problem hiding this comment.
When does this get updated?
(and will it need to be a v#.#.#?)
Member
Author
There was a problem hiding this comment.
That's what this PR is testing, and yeah, because I accidentally merged this morning before updating to a tag!
Member
Author
There was a problem hiding this comment.
So this PR will stop that mistake happening again -- CI / build-test will verify it
mcdurdin
added a commit
to keymanapp/api.keyman.com
that referenced
this pull request
Jun 16, 2026
Relates-to: keymanapp/keyman.com#794 Test-bot: skip
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
Jun 16, 2026
Relates-to: keymanapp/keyman.com#794 Test-bot: skip
This was referenced Jun 16, 2026
mcdurdin
added a commit
to keymanapp/s.keyman.com
that referenced
this pull request
Jun 16, 2026
Relates-to: keymanapp/keyman.com#794 Test-bot: skip
mcdurdin
added a commit
to keymanapp/shared-sites
that referenced
this pull request
Jun 16, 2026
…red-version (#99) Relates-to: keymanapp/keyman.com#794 Test-bot: skip
ermshiperete
approved these changes
Jun 16, 2026
mcdurdin
force-pushed
the
chore/verify-bootstrap-version
branch
from
c8e0a4d to
a9152a1
Compare
mcdurdin
added a commit
to keymanapp/api.keyman.com
that referenced
this pull request
Jun 16, 2026
Relates-to: keymanapp/keyman.com#794 Test-bot: skip
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
Jun 16, 2026
Relates-to: keymanapp/keyman.com#794 Test-bot: skip
mcdurdin
added a commit
to keymanapp/keymanweb.com
that referenced
this pull request
Jun 16, 2026
Relates-to: keymanapp/keyman.com#794 Test-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is important that the bootstrap version is pointing to a published tag, so that merged changes do not end up pointing to an ephemeral ref on the shared-sites repository. This change splits the bootstrap version into a separate file resources/.bootstrap-required-version, so that this version string can be easily checked in ci.yml, preventing merge of pull requests that point to branch names instead of tag names. For simplicity, the test verifies the shape of the version string as 'v#.#.#', but does not verify that it actually points to a tag, so in theory it could be fooled, but in practice we never use that pattern for branch names.
Test-bot: skip