Skip to content

Remove resolved_24h counter from alert summary specification #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarroutbi merged 1 commit into from
Apr 22, 2026
Merged

Remove resolved_24h counter from alert summary specification #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions spec/SDD-Keylime-Monitoring-Tool.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ New --> Acknowledged --> UnderInvestigation --> Resolved

**Terminal States:** `Resolved` and `Dismissed` reject all further transitions.

**Summary Computation:** The `critical`, `warnings`, and `info` counters returned by `GET /api/alerts/summary` count **all** alerts of their respective severity regardless of lifecycle state (including `Resolved` and `Dismissed`), matching the totals shown in the Alert Center list. `resolved_24h` counts `Resolved` alerts created within the last 24 hours. The Dashboard "Active Alerts" KPI sums only **active** (non-terminal) `critical + warnings` to represent alerts currently needing attention. All four counters are returned by `GET /api/alerts/summary`.
**Summary Computation:** The `critical`, `warnings`, and `info` counters returned by `GET /api/alerts/summary` count **all** alerts of their respective severity regardless of lifecycle state (including `Resolved` and `Dismissed`), matching the totals shown in the Alert Center list. The Dashboard "Active Alerts" KPI sums only **active** (non-terminal) `critical + warnings` to represent alerts currently needing attention. All three severity counters are returned by `GET /api/alerts/summary`.

**Trace:** Implementation -- `keylime-webtool-backend/src/models/alert_store.rs`

Expand Down Expand Up @@ -882,7 +882,6 @@ The frontend derives attestation KPIs from agent state data when no attestation
| Alert Center: Critical | From `GET /api/alerts/summary` -> `critical` (all states) |
| Alert Center: Warnings | From `GET /api/alerts/summary` -> `warnings` (all states) |
| Alert Center: Info | From `GET /api/alerts/summary` -> `info` (all states) |
| Alert Center: Resolved | From `GET /api/alerts/summary` -> `resolved_24h` |

**Rationale:** Ensures the dashboard displays meaningful data before TimescaleDB attestation history persistence is implemented.

Expand Down
4 changes: 2 additions & 2 deletions spec/SRS-Keylime-Monitoring-Tool.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,9 +1509,9 @@ Feature: Alert Lifecycle Workflow
And the resolution reason MUST indicate "auto-resolved on successful re-attestation"

Scenario: Alert Center KPI cards use consistent summary data
Given the alert summary endpoint returns critical=2, warnings=2, info=2, resolved_24h=0
Given the alert summary endpoint returns critical=2, warnings=2, info=2
When the user views the Alert Center page
Then all four KPI cards (Critical, Warnings, Info, Resolved) MUST display values from the summary endpoint
Then all three KPI cards (Critical, Warnings, Info) MUST display values from the summary endpoint
And the KPI values MUST NOT change when table filters are applied
```

Expand Down
Loading