confd: set IITO startup/failure conditions (fixes status LEDs) - #1587
confd: set IITO startup/failure conditions (fixes status LEDs)#1587pjator wants to merge 1 commit into
Conversation
|
When Currently, a condition is set when startup is applied: Line 844 in 279fc86 But there are no corresponding conditions for the failure cases. I suggest we add those and then update the IITO configuration to match. |
wkz
left a comment
wkz
left a comment
There was a problem hiding this comment.
Let's fix the root cause so that it (1) fixes all boards and (2) also fixes the error cases when startup fails to apply cleanly.
The product and common iitod.json configurations reference finit
conditions /run/finit/cond/run/startup/success and
/run/finit/cond/run/failure/{success,failure} to drive status LEDs,
but nothing ever creates them, so the LEDs stay dark on every boot.
confd already signals usr/bootstrap when startup applies; add the
matching conditions for a clean startup and for the failure paths
(fail-secure fallback and the fatal runlevel 9 case), which fixes
LED behaviour on all boards.
Co-authored-by: Jarvis (Hermes Agent) <jarvis@woxblom.com>
|
Fixed per your suggestion. confd now sets run/startup/success after a clean bootstrap and run/failure/success/run/failure/failure in handle_startup_failure() (fail-secure + panic paths). The board-specific workaround is dropped. Verified on hardware: LED lights on boot, eMMC visible. |
pjator
changed the title
2 participants
iitod.json expects /run/finit/cond/run/startup/success before the LAN and status LEDs light up, but nothing ever creates it. Add a small finit service (after confd/ready) that sets the condition on every boot.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: