docker: uprev logspec to 15d893c - #3191
Merged
Merged
Conversation
Pull in kernelci/logspec#29 ("kbuild: preserve generic error excerpts"), which fixes empty log_excerpt fields for generic kbuild failures. Before the fix, a failure such as make[5]: *** [/tmp/kci/linux/arch/x86/Makefile:269: arch/x86/include/generated/asm/cpufeaturemasks.h] Error 1 produced an issue with an empty excerpt, so the report mailed out had nothing between the "Log excerpt" markers. KbuildGenericError now keeps the full diagnostic line when the target appears within it, and falls back to the make failure itself when no preceding diagnostic exists. 370c994..15d893c: de0ad0a kbuild: preserve generic error excerpts 15d893c Merge pull request kernelci#29 from nuclearcat/fix-kbuild-empty-log-excerpt Reported-by: kernelci.org bot <bot@kernelci.org> Link: https://lore.kernel.org/all/178711194407.380.4108589457572337694@kernelci.org/ Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in kernelci/logspec#29 ("kbuild: preserve generic error excerpts"), merged as 15d893c.
Generic kbuild failures were producing issues with an empty
log_excerpt, so the mailed report had nothing between the "Log excerpt" markers:(https://lore.kernel.org/all/178711194407.380.4108589457572337694@kernelci.org/, dashboard: https://d.kernelci.org/i/maestro:e019eff33641f280144d13719cbbf59eb379327c)
KbuildGenericErrornow keeps the full diagnostic line when the failed target appears within it, and falls back to the make failure itself when there is no preceding diagnostic. Verified with this revision installed against kernelci-pipelinelogspec_api.py:370c994..15d893cis that one commit plus its merge, so the uprev carries no other parser changes.The headless comment line in the same report is a pipeline-side issue, fixed separately in kernelci/kernelci-pipeline#1584.