fix: Surface total SignalFx alert formatting failure - #6684
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6684 +/- ##
===========================================
- Coverage 46.42% 30.46% -15.96%
===========================================
Files 178 101 -77
Lines 18694 11773 -6921
===========================================
- Hits 8679 3587 -5092
+ Misses 10015 8186 -1829 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
Keep the existing per-incident isolation so one malformed incident does not discard valid alerts from the same response. Track whether formatting failures occurred and, after processing, raise a descriptive exception only when the upstream response was non-empty and no incident could be converted; preserve the original formatting failure as the cause where practical. Continue returning
[]for a genuinely empty response and returning the successful subset for mixed valid/invalid responses.SignalfxProvider._get_alertscatches and logs each incident-formatting exception, then returns the successfully formatted alerts. This preserves useful partial results, but when a non-empty API response contains only malformed incidents it returns[], making total data loss indistinguishable from a genuinely empty SignalFx response. Transport errors already propagate throughraise_for_status, so the defect is limited to the per-incident formatting boundary. The base provider'sget_alertsmethod already delegates to this method and will propagate its exception, so no caller or registry change is required.Closes #6674
✅ Checks
ℹ Additional Information
Nothing beyond what is described above.