Repository navigation
fix: a batch put back on a full capture queue drops the oldest, counted - #13
Merged
Merged
Conversation
When a batch didn't fit under the byte limit, the rest went back to the front with deque.extendleft; with the queue full of newer calls meanwhile, that evicted the newest, silently. The calls put back are the oldest: they are the ones dropped, and counted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in a bug sweep of the codebase.
When a capture batch didn't fit under the byte limit, the rest of it went back to the front of the queue:
deque.extendlefton a full queue evicted the newest calls, without counting them.The calls being put back are the oldest, so on a full queue they are now the ones dropped, and they are counted. That is the queue's own documented policy. New test:
putBack/_put_backwith a full queue.🤖 Generated with Claude Code