Repository navigation
Include spend from entities removed during the date range - #128
Merged
kLOsk merged 1 commit intoNov 8, 2026
Merged
Conversation
…ange Status is today's, metrics are the period's, so a status predicate hid spend from anything removed since. Drop the predicate from the campaign, impression-share, ad, keyword, audience and PMax campaign queries and drop REMOVED rows with zero impressions in Python instead (GAQL has no OR, and impressions > 0 alone would hide enabled campaigns with no impressions). Fixes kLOsk#120 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120.
get_campaign_performance(and its impression-share query),get_ad_performance,get_keyword_performance,get_audience_performanceandget_pmax_performance._drop_idle_removed()drops REMOVED rows with zero impressions in Python, so enabled campaigns with no impressions still show.tests/test_removed_in_date_range.py) assert the generated GAQL has no status predicate, a removed row with spend is kept, removed idle rows are dropped, enabled idle rows are kept, and compact totals include removed spend.Note:
get_audience_performancekeepsLIMIT 200, so idle removed rows now count toward that limit before Python drops them.