fix: canonical https repository URL in package.json#109
Open
jdjioe5-cpu wants to merge 1 commit into
Open
Conversation
Same fix as PR juliangruber#99 (which changed git:// -> ssh://); this commits the final canonical form (git+https://) which is what npm installs and modern tooling expects. GitHub disabled the unauthenticated git protocol in 2022, so any package.json that still has ssh:// or git:// for a GitHub-hosted project is broken for fresh installs.
jdjioe5-cpu
added a commit
to jdjioe5-cpu/isarray
that referenced
this pull request
Jun 20, 2026
jdjioe5-cpu
force-pushed
the
fix/public-repository-metadata
branch
from
a917a53 to
4729896
Compare
There was a problem hiding this comment.
Pull request overview
Updates the npm package metadata to use a canonical, tooling-friendly GitHub repository URL, aligning with modern expectations for repository.url.
Changes:
- Change
package.jsonrepository.urlfromssh://github.com/...togit+https://github.com/...
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
juliangruber
approved these changes
Jun 20, 2026
Owner
|
please set up commit signing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounty #2113 — same fix shape as brace-expansion#115 (also your repo, merged earlier today).
This package.json has
repository.url=ssh://github.com/juliangruber/isarray.git. This is broken:https://github.blog/security/application-security/improving-git-protocol-security-github/).ssh://for github.com without agit+prefix is non-canonical. npm, yarn, and modern tooling expectgit+https://.git://→ssh://on 2025-08-19), butssh://github.com/...is still broken for the same reason — the fix never went far enough.Diff (+1/-1 in package.json):
"repository": { "type": "git", - "url": "ssh://github.com/juliangruber/isarray.git" + "url": "git+https://github.com/juliangruber/isarray.git" },Verification:
git diff --checkclean.node -e "<11 test cases from test.js>"all pass — onlypackage.jsonchanged, source code untouched.No tests need to change because
test.jsdoes not exercisepackage.json. No source files change because this is purely metadata.