check which use of gfzrnx is done in header#236
Open
plutonheaven wants to merge 1 commit into
Open
Conversation
jtec
reviewed
Jul 8, 2026
| if "gfzrnx" in f.read(): | ||
| logging.warning(f"File {file} already contains 'gfzrnx', skipping repair.") | ||
| return file | ||
| def _check_gfzrnx_processing(file): |
Owner
There was a problem hiding this comment.
not sure this needs to be a nested function since it's called only once? If it needs to be a function, I'd make a it a module-level function so that it can be unit tested. If not, I'd just place it's code before the if _check_gfzrnx_processing(file):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #235
Check that both "gfzrnx" and "FILE PROCESSING" are in the header to decide whether to reprocess a file with gfzrnx.
This is due because some old files used gfzrnx to merge NAV files, but not check/repair them.