Skip to content

Faster GEO rotation#233

Merged
jtec merged 4 commits into
mainfrom
faster_rotations
Jun 19, 2026
Merged

Faster GEO rotation#233
jtec merged 4 commits into
mainfrom
faster_rotations

Conversation

@jtec

@jtec jtec commented Jun 17, 2026

Copy link
Copy Markdown
Owner

In datasets from receivers that track BDS GEO satellites, adding the velocity term when rotating between frames makes up a considerable chunk of prx's run time

prx_benchmark_main

With this change handle_bds_geos is about 10x as fast:

main: Function handle_bds_geos took 0 days 00:00:24.540819 to run.
2026-06-17 21:13:34,538 
branch: Function handle_bds_geos_faster took 0 days 00:00:02.708934 to run.

(checkout e24bc88 to compare)

Screenshot 2026-06-17 at 21 46 04

Testing

Running

pytest -k test_benchmark_geo_rotation

on e24bc88 compares old and new code.

jtec added 4 commits June 17, 2026 21:14
PASSED  [100%]2026-06-17 21:13:31,815 [DEBUG] [prx.util]: Function
handle_bds_geos took 0 days 00:00:24.540819 to run.
2026-06-17 21:13:34,538 [DEBUG] [prx.util]: Function
handle_bds_geos_faster took 0 days 00:00:02.708934 to run.
position_in_orbital_plane(eph)
orbital_plane_to_earth_centered_cartesian(eph)
handle_bds_geos(eph)
eph = handle_bds_geos(eph)

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most parts of the code we have functions return the modified dataframe.

Comment thread src/prx/test/benchmark.py

cases = generate_inputs(
n_steps=10,
n_steps=6,

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delivers results faster with enough resolution.

@jtec jtec requested a review from plutonheaven June 17, 2026 19:49
@jtec jtec marked this pull request as ready for review June 17, 2026 19:49

@plutonheaven plutonheaven left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jtec jtec merged commit a2d9cc0 into main Jun 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants