Skip to content

Refactor(tests): Prune test bloat, consolidate provisioner suite, and fix steering collision retry - #12

Merged
jtaroreh merged 1 commit into
mainfrom
refactor/test-bloat-reduction
Oct 23, 2026
Merged

jtaroreh merged 1 commit into
mainfrom
refactor/test-bloat-reduction

Conversation

@jtaroreh

Copy link
Copy Markdown
Owner

Summary

  • Test Bloat Pruned: Removed synthetic state machines, duplicate class aliases (TestStructuredOutputParsing, TestSwarmGenericHarvester), and non-hermetic host path checks.
  • Suite Consolidation: Moved TestSetupRuntimeProvisioner into tests/test_setup_runtime.py.
  • Bug Fix: Implemented sequence resolution retry loop in StorageMessenger.send_steer() and made _LocalBlob.upload_from_string() atomic with os.O_CREAT | os.O_EXCL, preventing file collision race conditions during concurrent steering.
  • Test Contract Restored: Restored tests 16, 17, and 18 in TestConversationalSteeringTool (covering concurrent steering, 412 precondition retries, and modular dispatch.mailbox_controller imports).
  • Orphan Cleanup: Removed dead imports in tests/test_cloud_preflight_and_worker.py and tests/test_container_spec.py.

Verification

  • Local suite: 314 tests passed (0 failures, 0 regressions)
  • Adversarial interrogation: completed with all review blockers resolved.

… fix steering collision retry

- Prune uncollected dead code, duplicate class aliases, and non-hermetic checks across test suites
- Relocate TestSetupRuntimeProvisioner into tests/test_setup_runtime.py
- Fix concurrency collision handling in StorageMessenger.send_steer with outer retry loop and atomic O_CREAT | O_EXCL file creation
- Restore tests 16, 17, and 18 inside TestConversationalSteeringTool
- Prune orphaned imports and attributes in test_cloud_preflight_and_worker.py and test_container_spec.py
- All 314 tests verified passing with zero regressions
@jtaroreh
jtaroreh merged commit d2ccb0a into main Oct 23, 2026
2 checks passed
@jtaroreh
jtaroreh deleted the refactor/test-bloat-reduction branch October 23, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant