Update new-multiplayer-adapter template for jsPsych.multiplayer namespace - #74
Open
htsukamoto5 wants to merge 1 commit into
Open
Update new-multiplayer-adapter template for jsPsych.multiplayer namespace#74htsukamoto5 wants to merge 1 commit into
htsukamoto5 wants to merge 1 commit into
Conversation
…yer namespace" This reverts commit 166de02.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new-multiplayer-adapter's scaffolding template to calljsPsych.multiplayer.connect()instead of the now-removedjsPsych.pluginAPI.connect(), matching the top-leveljsPsych.multiplayernamespace introduced in jspsych/jsPsych#3694.src/index.tsdoc comment — no logic changes, sinceMultiplayerAdapter's interface (connect,push,getAll,get,subscribe,disconnect,participantId) is unaffected by the rename.Test plan
new-multiplayer-adapternon-interactively to scaffold a test package and confirmed generated files referencejsPsych.multiplayer.connect()pluginAPI.connectorcommunicate()