[fix] avoid infinite loop in Response#isClientAbortException#450
Merged
Merged
Conversation
thimios
marked this pull request as ready for review
July 16, 2026 16:29
thimios
force-pushed
the
fix-client-abort-infinite-loop
branch
from
July 16, 2026 16:31
899d884 to
aec35a5
Compare
Contributor
|
Thx! This code looks a bit crazy, and I don't understand how it has sat here like this for so long, nor why I have never seen a problem from it myself... 🤔 |
Contributor
Author
It is very specific circumstances that would trigger the endless loop which we have been experiencing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #449.
Summary
isClientAbortExceptionwalks the exception cause chain but never advances it, so each iteration re-reads the same cause and re-assigns the same message. See more details in #449.The fix
Advance the chain via a separate
causevariable, and bound the traversal.The bound is necessary as a cause chain may be cyclic (
a.initCause(b); b.initCause(a)is possible), which would still hang acause = cause.getCause().