Repository navigation
Reject invalid Unicode scalars in encoded string nodes - #93
Merged
headius merged 2 commits intoNov 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joni parses a code point escape into a
StringNode. In UTF-16, encoding a surrogate code point can return a non-negative byte count whileEncoding.lengthreturns zero. The existing check only rejected negative lengths, so the invalid scalar reached optimizer analysis;OptExactInfo.concatStrthen repeatedly received a zero character length and did not advance.Route
StringNode.fromCodePointthroughcatCodeso both construction paths validate the encoded result, and reject zero as well as negative encoded lengths. The regression covers invalid surrogate and out-of-range escapes in UTF-16LE/BE and UTF-32LE/BE, plus valid U+1F600 matching.Verification
./mvnw -q -o -Dmaven.repo.local=/home/happier/workspace/jruby/.state/ruby-regexp-security-tests/maven/repository -Dtest=TestInvalidUnicodeEncoding test./mvnw -q -o -Dmaven.repo.local=/home/happier/workspace/jruby/.state/ruby-regexp-security-tests/maven/repository test— all test groups passed on Java 21.