Repository navigation
Let people turn off opening on hover, and open on click - #98
Open
jordan-cod wants to merge 1 commit into
Open
jordan-cod wants to merge 1 commit into
jordan-cod wants to merge 1 commit into
Conversation
Another notch app that also opens on hover fights with Pullo over the same spot. A General setting now turns hover opening off, and clicking the notch opens Pullo, so the shortcut isn't the only way left. Idea from @ZUBERKHAN034's fork.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
@ZUBERKHAN034 forked Pullo and added a setting to stop it opening on hover, so it wouldn't compete with other notch apps that also open on hover (fork). With hover off, the only way left to open Pullo was the keyboard shortcut, because clicking the closed notch did nothing.
What
openOnHover). When it's off, hovering over the closed notch no longer opens the panel. Alerts still drop down as usual.leftMouseDownon the panel callsNotchInteraction.clickedNotch(), which opens it when it's closed.NotchInteractionreads the setting fromAppSettingsdirectly instead of receiving it with every pointer move.Screenshots
Tests
hoveringCanBeTurnedOff: with the setting off, hovering doesn't open, and clicking does.clickingTheNotchOpensIt