Skip to content

[4.x] add missing tests #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heelc29 wants to merge 3 commits into
base: 4.x-dev
Choose a base branch
from
+214 −101
Open

[4.x] add missing tests #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd4e526
missing driver independent tests
heelc29 Jul 6, 2026
a1a4604
make tests/command db driver independent
heelc29 Jul 6, 2026
a80d687
Merge branch '4.x-dev' into 4.x/fix-missing-tests
heelc29 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,22 @@ jobs:
run: |
./vendor/bin/phpstan --error-format=github

tests-unit:
name: Run Unit tests
runs-on: ubuntu-latest
container: joomlaprojects/docker-images:php${{ matrix.php_version }}
needs: [code-style-php]
strategy:
matrix:
php_version: ['8.3', '8.4', '8.5']
steps:
- uses: actions/checkout@v6
- name: Run Unit tests
run: |
git config --global --add safe.directory $GITHUB_WORKSPACE
composer update
./vendor/bin/phpunit

tests-unit-sqlite:
name: Run Unit tests on SQLite
runs-on: ubuntu-latest
Expand Down
189 changes: 117 additions & 72 deletions Tests/Command/ExportCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@
use Joomla\Console\Application;
use Joomla\Database\Command\ExportCommand;
use Joomla\Database\DatabaseDriver;
use Joomla\Database\Exception\ExecutionFailureException;
use Joomla\Database\DatabaseExporter;
use Joomla\Database\Exception\UnsupportedAdapterException;
use Joomla\Filesystem\Folder;
use Joomla\Test\DatabaseTestCase;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput;

/**
* Test class for Joomla\Database\Command\ExportCommand
*/
class ExportCommandTest extends DatabaseTestCase
class ExportCommandTest extends TestCase
{
/**
* Path to the test space
Expand Down Expand Up @@ -48,10 +48,6 @@ public static function setUpBeforeClass(): void
}

parent::setUpBeforeClass();

if (!static::$connection || static::$connection->getName() !== 'mysql') {
self::markTestSkipped('MySQL database not configured.');
}
}

/**
Expand All @@ -64,20 +60,6 @@ protected function setUp(): void
{
parent::setUp();

try {
foreach (DatabaseDriver::splitSql(file_get_contents(dirname(__DIR__) . '/Stubs/Schema/mysql.sql')) as $query) {
static::$connection->setQuery($query)
->execute();
}
} catch (ExecutionFailureException $exception) {
$this->markTestSkipped(
\sprintf(
'Could not load MySQL database: %s',
$exception->getMessage()
)
);
}

$this->umask = umask(0);
$this->testPath = sys_get_temp_dir() . '/' . microtime(true) . '.' . mt_rand();

Expand All @@ -98,55 +80,35 @@ protected function tearDown(): void

umask($this->umask);

foreach (static::$connection->getTableList() as $table) {
static::$connection->dropTable($table);
}

parent::tearDown();
}

/**
* Loads the example data into the database.
*
* @return void
*/
protected function loadExampleData(): void
{
$data = [
(object) [
'id' => 1,
'title' => 'Testing1',
'start_date' => '2019-10-26 00:00:00',
'description' => 'test row one',
],
(object) [
'id' => 2,
'title' => 'Testing2',
'start_date' => '2019-10-26 00:00:00',
'description' => 'test row two',
],
(object) [
'id' => 3,
'title' => 'Testing3',
'start_date' => '2019-10-26 00:00:00',
'description' => 'test row three',
],
(object) [
'id' => 4,
'title' => 'Testing4',
'start_date' => '2019-10-26 00:00:00',
'description' => 'test row four',
],
];

foreach ($data as $row) {
static::$connection->insertObject('#__dbtest', $row);
}
}

public function testTheDatabaseIsExportedWithAllTables()
{
$this->loadExampleData();
$db = $this->createMock(DatabaseDriver::class);
$exporter = $this->createMock(DatabaseExporter::class);

$exporter->expects($this->once())
->method('withStructure')
->with(true)
->willReturnSelf();
$exporter->expects($this->exactly(2))
->method('withData')
->with(true)
->willReturnSelf();
$exporter->expects($this->exactly(2))
->method('from')
->willReturnSelf();

$db->expects($this->once())
->method('getExporter')
->willReturn($exporter);
$db->expects($this->once())
->method('getTableList')
->willReturn(['dbtest', 'dbtest2']);
$db->expects($this->once())
->method('getPrefix')
->willReturn('');

$input = new ArrayInput(
[
Expand All @@ -158,18 +120,47 @@ public function testTheDatabaseIsExportedWithAllTables()

$application = new Application($input, $output);

$command = new ExportCommand(static::$connection);
$command = new ExportCommand($db);
$command->setApplication($application);

$this->assertSame(0, $command->execute($input, $output));
$this->assertTrue(is_file($this->testPath . '/dbtest.xml'));
$this->assertTrue(is_file($this->testPath . '/dbtest2.xml'));

$screenOutput = $output->fetch();
$this->assertStringContainsString('Processing the dbtest table', $screenOutput);
$this->assertStringContainsString('Exported data for dbtest in', $screenOutput);
$this->assertStringContainsString('Processing the dbtest2 table', $screenOutput);
$this->assertStringContainsString('Exported data for dbtest2 in', $screenOutput);
$this->assertStringContainsString('Export completed in', $screenOutput);
}

public function testTheDatabaseIsExportedWithAllTablesInZipFormat()
{
$this->loadExampleData();
$db = $this->createMock(DatabaseDriver::class);
$exporter = $this->createMock(DatabaseExporter::class);

$exporter->expects($this->once())
->method('withStructure')
->with(true)
->willReturnSelf();
$exporter->expects($this->exactly(2))
->method('withData')
->with(true)
->willReturnSelf();
$exporter->expects($this->exactly(2))
->method('from')
->willReturnSelf();

$db->expects($this->once())
->method('getExporter')
->willReturn($exporter);
$db->expects($this->once())
->method('getTableList')
->willReturn(['dbtest', 'dbtest2']);
$db->expects($this->once())
->method('getPrefix')
->willReturn('');

$input = new ArrayInput(
[
Expand All @@ -182,18 +173,46 @@ public function testTheDatabaseIsExportedWithAllTablesInZipFormat()

$application = new Application($input, $output);

$command = new ExportCommand(static::$connection);
$command = new ExportCommand($db);
$command->setApplication($application);

$this->assertSame(0, $command->execute($input, $output));
$this->assertCount(1, glob($this->testPath . '/data_exported_*.zip'));

$screenOutput = $output->fetch();
$this->assertStringContainsString('Processing the dbtest table', $screenOutput);
$this->assertStringContainsString('Exported data for dbtest in', $screenOutput);
$this->assertStringContainsString('Processing the dbtest2 table', $screenOutput);
$this->assertStringContainsString('Exported data for dbtest2 in', $screenOutput);
$this->assertStringContainsString('Export completed in', $screenOutput);
}

public function testTheDatabaseIsExportedWithASingleTable()
{
$this->loadExampleData();
$db = $this->createMock(DatabaseDriver::class);
$exporter = $this->createMock(DatabaseExporter::class);

$exporter->expects($this->once())
->method('withStructure')
->with(true)
->willReturnSelf();
$exporter->expects($this->once())
->method('withData')
->with(true)
->willReturnSelf();
$exporter->expects($this->once())
->method('from')
->willReturnSelf();

$db->expects($this->once())
->method('getExporter')
->willReturn($exporter);
$db->expects($this->once())
->method('getTableList')
->willReturn(['dbtest', 'dbtest2']);
$db->expects($this->once())
->method('getPrefix')
->willReturn('');

$input = new ArrayInput(
[
Expand All @@ -206,12 +225,16 @@ public function testTheDatabaseIsExportedWithASingleTable()

$application = new Application($input, $output);

$command = new ExportCommand(static::$connection);
$command = new ExportCommand($db);
$command->setApplication($application);

$this->assertSame(0, $command->execute($input, $output));
$this->assertTrue(is_file($this->testPath . '/dbtest.xml'));
$this->assertFalse(is_file($this->testPath . '/dbtest2.xml'));

$screenOutput = $output->fetch();
$this->assertStringContainsString('Processing the dbtest table', $screenOutput);
$this->assertStringContainsString('Exported data for dbtest in', $screenOutput);
$this->assertStringContainsString('Export completed in', $screenOutput);
}

Expand Down Expand Up @@ -247,7 +270,29 @@ public function testTheCommandFailsIfTheDatabaseDriverDoesNotSupportExports()

public function testTheCommandFailsIfTheRequestedTableDoesNotExistInTheDatabase()
{
$this->loadExampleData();
$db = $this->createMock(DatabaseDriver::class);
$exporter = $this->createMock(DatabaseExporter::class);

$exporter->expects($this->once())
->method('withStructure')
->with(true)
->willReturnSelf();
$exporter->expects($this->never())
->method('withData')
->willReturnSelf();
$exporter->expects($this->never())
->method('from')
->willReturnSelf();

$db->expects($this->once())
->method('getExporter')
->willReturn($exporter);
$db->expects($this->once())
->method('getTableList')
->willReturn(['dbtest']);
$db->expects($this->once())
->method('getPrefix')
->willReturn('');

$input = new ArrayInput(
[
Expand All @@ -260,7 +305,7 @@ public function testTheCommandFailsIfTheRequestedTableDoesNotExistInTheDatabase(

$application = new Application($input, $output);

$command = new ExportCommand(static::$connection);
$command = new ExportCommand($db);
$command->setApplication($application);

$this->assertSame(1, $command->execute($input, $output));
Expand Down
Loading
Loading