[4.x] fix connection pgsql (ci)#365
Open
heelc29 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
JOOMLA_TEST_DB_HOSTshould match service name of workflow fileJOOMLA_TEST_DB_PORTd efault postgres port is 5432JOOMLA_TEST_DB_USERshould match environment variablePOSTGRES_USERJOOMLA_TEST_DB_PASSWORDshould match environment variablePOSTGRES_PASSWORDpostgres was handle different in travis (drone im not sure it worked).
The database base was created with commands and manual import the test data. In GitHub Actions we set environment variable
POSTGRES_DBto create the database.database/.travis.yml
Lines 229 to 231 in 1944153
database/.drone.jsonnet
Lines 170 to 173 in ff7ee96
This PR adjust the handling of test data like mysql/mysqli.
Testing Instructions
ci/cd
Documentation Changes Required
no