Fix the public-safety check: avoid the word "token" - #32
Merged
Conversation
The public-safety grep bans "token" because it normally means a credential. The Shopee title-search guidance added in joomcode#31 used it in the linguistic sense ("search short tokens"), which tripped the check on nine lines across two skills and left main red. Reworded to "terms", which reads better for search guidance anyway. No behaviour change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
profunctor
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently red: the public-safety grep banstokenbecause it normally means a credential, and the Shopee title-search guidance merged in #31 used the word in its linguistic sense — "search short tokens" — tripping the check on nine lines across two skills.Reworded to "terms", which reads more naturally for search guidance anyway:
pulse-find-exact-same-product— 6 occurrencesml-product-analysis— 3 occurrencesNo behaviour change; the guidance is identical.
bash scripts/check-public-safety.shpasses locally, and the description gates (≤1024 characters, no angle brackets) still pass for all skills.🤖 Generated with Claude Code