chore: use Effect Console in @effex/platform instead of raw console.*#46
Merged
Conversation
Same rationale as the equivalent change in @effex/dom's subscribeReconcile — Effect's Console goes through a service (Layer-swappable for tests), returns Effect<void> directly (no Effect.sync wrapping), and is more idiomatic in an otherwise Effect-native codebase. Default sink still delegates to the real console. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2 tasks
Deploying effex with
|
| Latest commit: |
5587f24
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e85079b6.effex.pages.dev |
| Branch Preview URL: | https://chore-platform-effect-consol.effex.pages.dev |
Deploying effex-api with
|
| Latest commit: |
5587f24
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d48eddc.effex-api.pages.dev |
| Branch Preview URL: | https://chore-platform-effect-consol.effex-api.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on the merged PRs #41 (data-provider fallback) — swap raw `console.error` / `console.warn` / `console.log` for Effect's `Console` service everywhere in `@effex/platform`.
Why
Every log site in Platform is already inside an `Effect` chain, so wrapping `console.*` in `Effect.sync` (as those PRs did) was unnecessarily un-Effect-native. Effect's `Console.error` / `Console.warn` / `Console.log`:
Default sink still delegates to the real browser/Node console, so existing spy-based tests keep working unchanged.
Sites updated
Test plan
🤖 Generated with Claude Code