Skip to content

Use composition in value instead of inheritance - #293

Merged
mrabine merged 2 commits into
mainfrom
value-composition
Oct 17, 2026
Merged

mrabine merged 2 commits into
mainfrom
value-composition

Conversation

@mrabine

@mrabine mrabine commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codacy-production

codacy-production Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 15 complexity · -3 duplication

Metric Results
Complexity 15
Duplication -3

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.02% coverage variation

Metric Results
Coverage variation ✅ +0.02% coverage variation
Diff coverage ✅ 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bc92594) 15853 15586 98.32%
Head commit (85e4db2) 15893 (+40) 15628 (+42) 98.33% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#293) 347 347 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.39%. Comparing base (bc92594) to head (85e4db2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   98.38%   98.39%   +0.01%     
==========================================
  Files         136      136              
  Lines       14941    14969      +28     
==========================================
+ Hits        14699    14729      +30     
+ Misses        242      240       -2     
Flag Coverage Δ
unittests 98.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

coveralls commented Oct 17, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 39077955010

Coverage increased (+0.02%) to 98.333%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 347 of 347 lines across 4 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15893
Covered Lines: 15628
Line Coverage: 98.33%
Coverage Strength: 227596.91 hits per line

💛 - Coveralls

@mrabine
mrabine merged commit c096f45 into main Oct 17, 2026
15 checks passed
@mrabine
mrabine deleted the value-composition branch October 17, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants