Skip to content

Policy pattern for SAX readers and writers - #292

Merged
mrabine merged 6 commits into
mainfrom
sax-handler-policy
Oct 17, 2026
Merged

mrabine merged 6 commits into
mainfrom
sax-handler-policy

Conversation

@mrabine

@mrabine mrabine commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codacy-production

codacy-production Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 123 complexity · 36 duplication

Metric Results
Complexity 123
Duplication 36

View in Codacy

🟢 Coverage 99.84% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation
Diff coverage ✅ 99.84% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6c5ed79) 15830 15563 98.31%
Head commit (ab75f3c) 15853 (+23) 15586 (+23) 98.32% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#292) 635 634 99.84%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coveralls

coveralls commented Oct 16, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 39061186970

Coverage increased (+0.003%) to 98.316%

Details

  • Coverage increased (+0.003%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (634 of 635 lines covered, 99.84%).
  • 4 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
data/include/join/json.hpp 221 220 99.55%
Total (5 files) 635 634 99.84%

Coverage Regressions

4 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
data/include/join/json.hpp 2 99.57%
data/include/join/pack.hpp 2 99.56%

Coverage Stats

Coverage Status
Relevant Lines: 15853
Covered Lines: 15586
Line Coverage: 98.32%
Coverage Strength: 226480.94 hits per line

💛 - Coveralls

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (6c5ed79) to head (ab75f3c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   98.37%   98.38%           
=======================================
  Files         136      136           
  Lines       14910    14941   +31     
=======================================
+ Hits        14668    14699   +31     
  Misses        242      242           
Flag Coverage Δ
unittests 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrabine
mrabine merged commit bc92594 into main Oct 17, 2026
23 of 24 checks passed
@mrabine
mrabine deleted the sax-handler-policy branch October 17, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants